linux-kernel - Re: [PATCH v3 1/1] usb: musb: gadget: misplaced out of bounds check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180320185555.GY14921@uda0271908>
Date:   Tue, 20 Mar 2018 13:55:55 -0500
From:   Bin Liu <b-liu@...com>
To:     Heinrich Schuchardt <xypron.glpk@....de>
CC:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/1] usb: musb: gadget: misplaced out of bounds check

Hi,

On Tue, Mar 20, 2018 at 07:42:48PM +0100, Heinrich Schuchardt wrote:
> musb->endpoints[] has array size MUSB_C_NUM_EPS.
> We must check array bounds before accessing the array and not afterwards.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@....de>
> ---
> v3
> 	Remove superfluous braces.
> v2
> 	Only the 4 low bits of epnum are relevant for indexing.
> ---
>  drivers/usb/musb/musb_gadget_ep0.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)


Applied. Thanks.

Regards,
-Bin.