linux-kernel - Re: [PATCH] staging: mt7621-gpio: remove redundant owner assignments of drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87d0zy8jty.fsf@notabene.neil.brown.name>
Date:   Wed, 21 Mar 2018 09:26:33 +1100
From:   NeilBrown <neil@...wn.name>
To:     hariprasath.elango@...il.com, blogic@...nwrt.org,
        gregkh@...uxfoundation.org
Cc:     gehariprasath@...il.com,
        HariPrasath Elango <hariprasath.elango@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: mt7621-gpio: remove redundant owner assignments of drivers

On Tue, Mar 20 2018, hariprasath.elango@...il.com wrote:

> From: HariPrasath Elango <hariprasath.elango@...il.com>
>
> Remove the reduntant owner initialization from this platform driver as
> the platform_driver_register() takes care of it.
>
> Signed-off-by: HariPrasath Elango <hariprasath.elango@...il.com>
> ---
>  drivers/staging/mt7621-gpio/gpio-mt7621.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/mt7621-gpio/gpio-mt7621.c b/drivers/staging/mt7621-gpio/gpio-mt7621.c
> index 5c57abe..830d429 100644
> --- a/drivers/staging/mt7621-gpio/gpio-mt7621.c
> +++ b/drivers/staging/mt7621-gpio/gpio-mt7621.c
> @@ -339,7 +339,6 @@ static struct platform_driver mediatek_gpio_driver = {
>  	.probe = mediatek_gpio_probe,
>  	.driver = {
>  		.name = "mt7621_gpio",
> -		.owner = THIS_MODULE,
>  		.of_match_table = mediatek_gpio_match,
>  	},
>  };
> -- 
> 2.10.0.GIT

Reviewed-by: NeilBrown <neil@...wn.name>

Thanks,
NeilBrown

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)