linux-kernel - Re: [PATCH 3/3] i2c: mux: pca9541: prepare for PCA9641 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67f0b5fb-5df7-0354-bfd6-5969b6fc7bb1@mleia.com>
Date:   Wed, 21 Mar 2018 09:01:33 +0200
From:   Vladimir Zapolskiy <vz@...ia.com>
To:     Guenter Roeck <linux@...ck-us.net>, Peter Rosin <peda@...ntia.se>,
        linux-kernel@...r.kernel.org, Ken Chen <chen.kenyy@...entec.com>
Cc:     Wolfram Sang <wsa@...-dreams.de>, joel@....id.au,
        linux-i2c@...r.kernel.org
Subject: Re: [PATCH 3/3] i2c: mux: pca9541: prepare for PCA9641 support

On 03/21/2018 03:19 AM, Guenter Roeck wrote:
> On 03/20/2018 04:17 PM, Vladimir Zapolskiy wrote:
>> Hi Peter, Ken,
>>
>> On 03/20/2018 11:32 AM, Peter Rosin wrote:
>>> Make the arbitrate and release_bus implementation chip specific.
>>>
>>
>> by chance I took a look at the original implementation done by Ken, and
>> I would say that this 3/3 change is an overkill as a too generic one.
>> Is there any next observable extension? And do two abstracted (*arbitrate)
>> and (*release_bus) cover it well? Probably no.
>>
>> At first it would be simpler to add a new chip id field into struct pca9541
>> (struct rename would be needed of course), and do a selection of specific
>> pca9x41_arbitrate() and pca9x41_release_bus() depending on it:
>>
> 
> FWIW, I very much prefer Peter's code. I think it is much cleaner.

Peter's code is generic, and it makes the change about 3 times longer in lines
of code, and the following pca9641 change on top of it will be larger as well,
because generalization requires service.

My main concern is that if such generalization is really needed in the driver.

--
With best wishes,
Vladimir