linux-kernel - Re: [PATCH 3/4] signal/x86: Move nosig handling at the end of exit_to_usermode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201803210929.40dSEA4q%fengguang.wu@intel.com>
Date:   Wed, 21 Mar 2018 09:39:20 +0800
From:   kbuild test robot <lkp@...el.com>
To:     NIIBE Yutaka <gniibe@...j.org>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org, gniibe@...j.org
Subject: Re: [PATCH 3/4] signal/x86: Move nosig handling at the end of
 exit_to_usermode_loop.

Hi NIIBE,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v4.16-rc4]
[also build test ERROR on next-20180320]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/NIIBE-Yutaka/Unblocked-by-fake_signal_wake_up-then-real-signal/20180321-051147
config: um-x86_64_defconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=um SUBARCH=x86_64

All errors (new ones prefixed by >>):

   In file included from arch/um/kernel/irq.c:17:0:
>> arch/um/include/shared/kern_util.h:26:13: error: conflicting types for 'do_signal'
    extern void do_signal(struct pt_regs *regs);
                ^~~~~~~~~
   In file included from include/uapi/linux/signal.h:5:0,
                    from include/linux/signal_types.h:10,
                    from include/linux/sched.h:27,
                    from include/linux/kernel_stat.h:10,
                    from arch/um/kernel/irq.c:11:
   arch/x86/include/asm/signal.h:38:12: note: previous declaration of 'do_signal' was here
    extern int do_signal(struct pt_regs *regs);
               ^~~~~~~~~
--
   In file included from arch/um/kernel/signal.c:13:0:
>> arch/um/include/shared/kern_util.h:26:13: error: conflicting types for 'do_signal'
    extern void do_signal(struct pt_regs *regs);
                ^~~~~~~~~
   In file included from include/uapi/linux/signal.h:5:0,
                    from include/linux/signal_types.h:10,
                    from include/linux/sched.h:27,
                    from include/linux/ptrace.h:6,
                    from arch/um/kernel/signal.c:7:
   arch/x86/include/asm/signal.h:38:12: note: previous declaration of 'do_signal' was here
    extern int do_signal(struct pt_regs *regs);
               ^~~~~~~~~
>> arch/um/kernel/signal.c:67:6: error: conflicting types for 'do_signal'
    void do_signal(struct pt_regs *regs)
         ^~~~~~~~~
   In file included from include/uapi/linux/signal.h:5:0,
                    from include/linux/signal_types.h:10,
                    from include/linux/sched.h:27,
                    from include/linux/ptrace.h:6,
                    from arch/um/kernel/signal.c:7:
   arch/x86/include/asm/signal.h:38:12: note: previous declaration of 'do_signal' was here
    extern int do_signal(struct pt_regs *regs);
               ^~~~~~~~~

vim +/do_signal +26 arch/um/include/shared/kern_util.h

edea13858 arch/um/include/kern_util.h        Jeff Dike     2008-02-04  24  
ccaee5f85 arch/um/include/shared/kern_util.h Ingo Molnar   2015-07-03  25  struct pt_regs;
ccaee5f85 arch/um/include/shared/kern_util.h Ingo Molnar   2015-07-03 @26  extern void do_signal(struct pt_regs *regs);
edea13858 arch/um/include/kern_util.h        Jeff Dike     2008-02-04  27  extern void interrupt_end(void);
d3c1cfcdb arch/um/include/shared/kern_util.h Martin Pärtel 2012-08-02  28  extern void relay_signal(int sig, struct siginfo *si, struct uml_pt_regs *regs);
edea13858 arch/um/include/kern_util.h        Jeff Dike     2008-02-04  29  

:::::: The code at line 26 was first introduced by commit
:::::: ccaee5f851470dec6894a6835b6fadffc2bb7514 um: Fix do_signal() prototype

:::::: TO: Ingo Molnar <mingo@...nel.org>
:::::: CC: Ingo Molnar <mingo@...nel.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (8114 bytes)