linux-kernel - RE: [PATCH] staging: fsl-dpaa2: replace simple switch case by if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <faa92f0e20fc44019ee0b64b04413d69@AcuMS.aculab.com>
Date:   Wed, 21 Mar 2018 11:48:08 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     "'hariprasath.elango@...il.com'" <hariprasath.elango@...il.com>,
        "ruxandra.radulescu@....com" <ruxandra.radulescu@....com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "gehariprasath@...il.com" <gehariprasath@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>
Subject: RE: [PATCH] staging: fsl-dpaa2: replace simple switch case by if
 statement

From: > hariprasath.elango@...il.com
> Sent: 21 March 2018 11:16
> From: HariPrasath Elango <hariprasath.elango@...il.com>
> 
> Replace a couple of simple switch cases by if condition

Why?
In principle extra 'case' might be needed in the future.

...
> diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c b/drivers/staging/fsl-
> dpaa2/ethernet/dpaa2-ethtool.c
> index 070a3f2..fb517cb 100644
> --- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
> +++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
> @@ -171,8 +171,7 @@ static void dpaa2_eth_get_strings(struct net_device *netdev, u32 stringset,
>  	u8 *p = data;
>  	int i;
> 
> -	switch (stringset) {
> -	case ETH_SS_STATS:
> +	if (stringset == ETH_SS_STATS) {
>  		for (i = 0; i < DPAA2_ETH_NUM_STATS; i++) {
>  			strlcpy(p, dpaa2_ethtool_stats[i], ETH_GSTRING_LEN);
>  			p += ETH_GSTRING_LEN;
> @@ -181,18 +180,16 @@ static void dpaa2_eth_get_strings(struct net_device *netdev, u32 stringset,
>  			strlcpy(p, dpaa2_ethtool_extras[i], ETH_GSTRING_LEN);
>  			p += ETH_GSTRING_LEN;
>  		}
> -		break;
>  	}
>  }
...

	David