linux-kernel - Re: [PATCH 5/8] remoteproc: da8xx: add the missing checke for clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f528a120-d6e8-ff6f-243a-256ce4c392a9@lechnology.com>
Date:   Wed, 21 Mar 2018 11:21:04 -0500
From:   David Lechner <david@...hnology.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>, Sekhar Nori <nsekhar@...com>,
        Kevin Hilman <khilman@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Ohad Ben-Cohen <ohad@...ery.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Philipp Zabel <p.zabel@...gutronix.de>
Cc:     linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-remoteproc@...r.kernel.org,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH 5/8] remoteproc: da8xx: add the missing checke for
 clk_enable()

On 03/21/2018 07:08 AM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> 
> The davinci platform is being switched to using the common clock
> framework, where clk_enable() can fail. Add the return value check.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
> ---
>   drivers/remoteproc/da8xx_remoteproc.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
> index bf3b9034c319..592bf0fc52e8 100644
> --- a/drivers/remoteproc/da8xx_remoteproc.c
> +++ b/drivers/remoteproc/da8xx_remoteproc.c
> @@ -138,6 +138,7 @@ static int da8xx_rproc_start(struct rproc *rproc)
>   	struct device *dev = rproc->dev.parent;
>   	struct da8xx_rproc *drproc = (struct da8xx_rproc *)rproc->priv;
>   	struct clk *dsp_clk = drproc->dsp_clk;
> +	int rv;

For style points, you could use ret instead of rv to be consistent with
the rest of this driver.

>   
>   	/* hw requires the start (boot) address be on 1KB boundary */
>   	if (rproc->bootaddr & 0x3ff) {
> @@ -148,7 +149,12 @@ static int da8xx_rproc_start(struct rproc *rproc)
>   
>   	writel(rproc->bootaddr, drproc->bootreg);
>   
> -	clk_enable(dsp_clk);
> +	rv = clk_enable(dsp_clk);
> +	if (rv) {
> +		dev_err(dev, "clk_enable() failed: %d\n", rv);
> +		return rv;
> +	}
> +
>   	davinci_clk_reset_deassert(dsp_clk);
>   
>   	return 0;
>