linux-kernel - Re: [PATCHv2 2/2] bpftool: Adjust to new print_bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83bca487-ade9-7b8e-c303-11256ce50d77@netronome.com>
Date:   Wed, 21 Mar 2018 17:30:30 +0000
From:   Quentin Monnet <quentin.monnet@...ronome.com>
To:     Jiri Olsa <jolsa@...hat.com>,
        Daniel Borkmann <daniel@...earbox.net>
Cc:     Jiri Olsa <jolsa@...nel.org>, Alexei Starovoitov <ast@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org
Subject: Re: [PATCHv2 2/2] bpftool: Adjust to new print_bpf_insn interface

2018-03-21 18:00 UTC+0100 ~ Jiri Olsa <jolsa@...hat.com>
> On Wed, Mar 21, 2018 at 05:44:52PM +0100, Daniel Borkmann wrote:
> 
> SNIP
> 
>>>> Hi Jiri, this code has changed in the tree. It was moved to
>>>> tools/bpf/bpftool/xlated_dumper.c, and there is now a third function to
>>>> update: print_insn_for_graph(). Could you please rebase the patch?
>>>
>>> sure.. I was over perf tree, I'll check on bpf tree
>>
>> Just to be sure, it should be bpf-next. bpf is for fixes only.
> 
> v2 attached
> 
> thanks,
> jirka
> 
> 
> ---
> Change bpftool to skip the removed struct bpf_verifier_env
> argument in print_bpf_insn. It was passed as NULL anyway.
> 
> No functional change intended.
> 
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> ---
>  tools/bpf/bpftool/xlated_dumper.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 

Thank you!
Reviewed-by: Quentin Monnet <quentin.monnet@...ronome.com>