linux-kernel - Re: [PATCH 1/1] Bluetooth: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for BTUSB_QCA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180321193814.GB19781@kroah.com>
Date:   Wed, 21 Mar 2018 20:38:14 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Harsh Shandilya <msfjarvis@...il.com>
Cc:     Vic Wei <vwei@...eaurora.org>, marcel@...tmann.org,
        linux-kernel@...r.kernel.org, majordomo@...r.kernel.org,
        stable@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-arm-kernel@...r.kernel.org, kumo@....qualcomm.com,
        vwei@....qualcomm.com
Subject: Re: [PATCH 1/1] Bluetooth: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for
 BTUSB_QCA_ROME

On Wed, Mar 21, 2018 at 11:40:07PM +0530, Harsh Shandilya wrote:
> 
> 
> On 21 March 2018 9:54:37 PM IST, Greg KH <gregkh@...uxfoundation.org> wrote:
> >On Wed, Mar 21, 2018 at 09:09:57AM -0700, Vic Wei wrote:
> >> QCA Rome controllers can do both LE scan and BR/EDR inquiry at once.
> >> 
> >> Change-Id: I89e1412d635f4cd7b2500f7492f37430ea139f0c
> >
> >What is this line for?
> 
> That's the Change ID required by everything that goes through Gerrit. CAF (I'm assuming Vic is from CodeAurora Forums judging by the email) uses Gerrit as their review platform for the Android for MSM project.

It was a rhetorical question, I know what it is, and the fact that it
should not be in a kernel patch submission, I wanted the submitter to
learn to read their own patches _before_ they send them in.

Also, if they used checkpatch.pl, it would have told them to remove
this.

It's like saying to a kid, "what is this mess on the floor"...

greg k-h