linux-kernel - Re: [PATCH v2 1/2] dma-mapping: move dma configuration to bus infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180322081705.GB29444@lst.de>
Date:   Thu, 22 Mar 2018 09:17:05 +0100
From:   "hch@....de" <hch@....de>
To:     Bharat Bhushan <bharat.bhushan@....com>
Cc:     Nipun Gupta <nipun.gupta@....com>,
        "robin.murphy@....com" <robin.murphy@....com>,
        "hch@....de" <hch@....de>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "m.szyprowski@...sung.com" <m.szyprowski@...sung.com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "zajec5@...il.com" <zajec5@...il.com>,
        "andy.gross@...aro.org" <andy.gross@...aro.org>,
        "david.brown@...aro.org" <david.brown@...aro.org>,
        "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        "vinod.koul@...el.com" <vinod.koul@...el.com>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "frowand.list@...il.com" <frowand.list@...il.com>,
        "jarkko.sakkinen@...ux.intel.com" <jarkko.sakkinen@...ux.intel.com>,
        "rafael.j.wysocki@...el.com" <rafael.j.wysocki@...el.com>,
        "dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
        "johan@...nel.org" <johan@...nel.org>,
        "msuchanek@...e.de" <msuchanek@...e.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        "linux-soc@...r.kernel.org" <linux-soc@...r.kernel.org>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        Leo Li <leoyang.li@....com>
Subject: Re: [PATCH v2 1/2] dma-mapping: move dma configuration to bus
        infrastructure

> > +int dma_configure(struct device *dev)
> > +{
> > +	if (dev->bus->dma_configure)
> > +		return dev->bus->dma_configure(dev);
> 
> What if dma_common_configure() is called in case "bus->dma_configure" is not defined?

Then we'd still have a dependency of common code on OF and ACPI.

On the other hand we'd get free OF and ACPI dma ranges parsing for
everyone, which might be handy.  And which would really help mitigating
the risk that we missed some bus that gets dma configuration from OF,
so maybe it actually is a good idea.  I'd just rename it to
dma_default_configure or similar in that case.