linux-kernel - Re: [PATCH] serial: samsung: macros with complex values should be enclosed in parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 22 Mar 2018 18:04:50 +0900
From:   YOUNGKEUN OH <y.k.oh@...sung.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     jslaby@...e.com, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] serial: samsung: macros with complex values should be
 enclosed in parentheses



On 03/22/2018 05:45 PM, Greg KH wrote:
> On Thu, Mar 22, 2018 at 01:37:45PM +0900, y.k.oh wrote:
>>
>>
>> On 03/14/2018 10:58 PM, Greg KH wrote:
>>> On Wed, Mar 14, 2018 at 11:17:05AM +0900, YOUNGKEUN OH wrote:
>>>> Cleanup checkpatch error:
>>>> ERROR: Macros with complex values should be enclosed in parentheses
>>>>
>>>> Signed-off-by: YOUNGKEUN OH <y.k.oh@...sung.com>
>>>> ---
>>>>  drivers/tty/serial/samsung.c | 16 ++++++++--------
>>>>  1 file changed, 8 insertions(+), 8 deletions(-)
>>>>
>>>> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
>>>> index 3f2f8c1..da9bddb1 100644
>>>> --- a/drivers/tty/serial/samsung.c
>>>> +++ b/drivers/tty/serial/samsung.c
>>>> @@ -1455,7 +1455,7 @@ static int __init s3c24xx_serial_console_init(void)
>>>>  }
>>>>  console_initcall(s3c24xx_serial_console_init);
>>>>
>>>> -#define S3C24XX_SERIAL_CONSOLE &s3c24xx_serial_console
>>>> +#define S3C24XX_SERIAL_CONSOLE (&s3c24xx_serial_console)
>>>
>>> That's not a complex macro!
>>>
>>> Please use checkpatch as a hint, not the "truth".
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>> Dear Greg.
>>
>> Yes! Of course that's not a pretty complex macro. However, I think it is
>> important to make a small effort to modify the minimum standard,
>> Checkpatch ERROR, to ensure consistency in the Linux code.
>> Starting with this Checkpatch error of samsung.c, I would like to start
>> my efforts on contribution from a small point.  Please review it again.
> 
> Why would I review something again that is not correct?
> 
> If you wish to start out in kernel development, please start in
> drivers/staging/*/TODO, not in "core" kernel code.  That is what the
> drivers/staging/ code is there for.
> 
> good luck!
> 
> greg k-h
> 
Dear Greg.

Thank you for your comment. I'll see you soon with a good patch.

Sincerely,
Youngkeun Oh