linux-kernel - Re: [PATCH 2/7] PM / OPP: Implement of_dev_pm_opp_find_required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFoeAnCcG-0S_uFoXOBD1eppysRv=8zBXvxS13BUba9UJw@mail.gmail.com>
Date:   Thu, 22 Mar 2018 10:29:15 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Kevin Hilman <khilman@...nel.org>,
        Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linux PM <linux-pm@...r.kernel.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        Sudeep Holla <sudeep.holla@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/7] PM / OPP: Implement of_dev_pm_opp_find_required_opp()

On 22 December 2017 at 08:26, Viresh Kumar <viresh.kumar@...aro.org> wrote:
> A device's DT node or its OPP nodes can contain a phandle to other
> device's OPP node, in the "required-opp" property.
>
> This patch implements a routine to find that required OPP from the node
> that contains the "required-opp" property.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>

[...]

> +++ b/include/linux/pm_opp.h
> @@ -309,6 +309,7 @@ int dev_pm_opp_of_cpumask_add_table(const struct cpumask *cpumask);
>  void dev_pm_opp_of_cpumask_remove_table(const struct cpumask *cpumask);
>  int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev, struct cpumask *cpumask);
>  struct device_node *dev_pm_opp_of_get_opp_desc_node(struct device *dev);
> +struct dev_pm_opp *of_dev_pm_opp_find_required_opp(struct device *dev, struct device_node *np);

I find the name of the exported function a bit "too" self-explainable,
opp...opp. :-)

However it's consistent with the existing APIs.

[...]

Reviewed-by: Ulf Hansson <ulf.hansson@...aro.org>

Kind regards
Uffe