linux-kernel - RE: Re: [PATCH 0/2] rbd: thick-provision image support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C8603108370B1949BF3CC7742DDE5D35B8B39FF8@GSjpTKYDCembx31.service.hitachi.net>
Date:   Thu, 22 Mar 2018 11:58:38 +0000
From:   亀井仁志 / KAMEI，HITOSHI 
        <hitoshi.kamei.xm@...achi.com>
To:     Ilya Dryomov <idryomov@...il.com>
CC:     Sage Weil <sage@...hat.com>, Alex Elder <elder@...nel.org>,
        "Ceph Development" <ceph-devel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: Re: [PATCH 0/2] rbd: thick-provision image support

Hi Ilya, 

> I think it should be a map time option -- e.g. rbd map -o thick.
> I don't see any reason for allowing tweaking this setting on a mapped image.

I will add such option to rbd map command. The modified rbd command
with the option writes "1" to sysfs file to disable discard operation at
run-time. And, when user programs issue discard request to an image
with the option, the patched kernel rbd driver ignores the discard
request.

Current kernel rbd driver always discards allocated blocks on an image
when user programs issue discard operation. For example, when an rbd image
is formatted by mkfs.xfs, the mkfs.xfs issues discard request and the 
kernel rbd driver discards allocated blocks. However, the kernel rbd driver
should keep all blocks of thick/fully provisioned image. This patch allows
the kernel rbd driver to ignore discard request for thick/fully provisioned
image.

> I looked through https://github.com/ceph/ceph/pull/18317 and I don't
> see an equivalent functionality there.  rbd_discard_on_zeroed_write_same
> set to false makes the actual zeroes go on the wire, but I don't see
> anything for ignoring discard requests.  Can you point me at that?

As Jason said, there is not currently an option in librbd. And the rbd
command also does not have any options for this patch. I will add the option
to rbd map command in the next step.

And, the reason why the previous email refers to the URL is that this patch
series is related to the thick/fully provisioned image described above.

Regards,

-- 
Hitoshi Kamei