linux-kernel - Re: [usb-next, v2 PATCH] usb: xhci: skip phys initialization of shared hcd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Mar 2018 13:00:21 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Chunfeng Yun <chunfeng.yun@...iatek.com>
Cc:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Roger Quadros <rogerq@...com>, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-usb@...r.kernel.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [usb-next, v2 PATCH] usb: xhci: skip phys initialization of
 shared hcd

On Thu, Mar 22, 2018 at 05:21:26PM +0800, Chunfeng Yun wrote:
> hi, 
> On Thu, 2018-03-22 at 10:01 +0100, Greg Kroah-Hartman wrote:
> > On Thu, Mar 22, 2018 at 04:39:20PM +0800, Chunfeng Yun wrote:
> > > The phys has already been initialized when add primary hcd,
> > > including usb2 phys and usb3 phys also if exist, so needn't
> > > re-parse "phys" property again.
> > > 
> > > Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com>
> > > ---
> > >  drivers/usb/core/hcd.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > What changed from version 1?
> V1: skip phys initialization when add shared HCD by setting
> xhci->shared_hcd->skip_phy_initialization=1;
> for both xhci-plat.c & xhci-mtk.c files.
> 
> V2: fix it in hcd.c suggested by Roger

Please put it in the patch itself, resend v3 with this info.

thanks,

greg k-h