linux-kernel - Re: [PATCH][next] phy: qcom-qusb2: fix missing assignment to an error return code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <40d4e9a6-86c0-4f1d-4768-b27209ab4890@codeaurora.org>
Date:   Thu, 22 Mar 2018 08:07:46 +0530
From:   Vivek Gautam <vivek.gautam@...eaurora.org>
To:     Colin King <colin.king@...onical.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Manu Gautam <mgautam@...eaurora.org>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] phy: qcom-qusb2: fix missing assignment to an error
 return code



On 3/21/2018 11:15 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> The error return code is not being assigned to ret from the call
> to clk_prepare_enable and consequently the current check on ret
> picks up the previous error return. Fix this by adding in the
> missing assignment to ret.
>
> Detected by CoverityScan, CID#166020 ("Logically Dead code")
>
> Fixes: 891a96f65ac3 ("phy: qcom-qusb2: Add support for runtime PM)
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---

Acked-by: Vivek Gautam <vivek.gautam@...eaurora.org>

regards
Vivek

>   drivers/phy/qualcomm/phy-qcom-qusb2.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c
> index 94afeac1a19e..6f5689a40884 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qusb2.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c
> @@ -439,7 +439,7 @@ static int __maybe_unused qusb2_phy_runtime_resume(struct device *dev)
>   	}
>   
>   	if (!qphy->has_se_clk_scheme) {
> -		clk_prepare_enable(qphy->ref_clk);
> +		ret = clk_prepare_enable(qphy->ref_clk);
>   		if (ret) {
>   			dev_err(dev, "failed to enable ref clk, %d\n", ret);
>   			goto disable_ahb_clk;