linux-kernel - Re: [PATCH] net/mlx5/core/fpga/ipsec: Fix use-after-free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 22 Mar 2018 13:37:29 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Yuval Shaia <yuval.shaia@...cle.com>
Cc:     Ilan Tayari <ilant@...lanox.com>,
        Boris Pismenny <borisp@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Matan Barak <matanb@...lanox.com>,
        Leon Romanovsky <leon@...nel.org>, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/mlx5/core/fpga/ipsec: Fix use-after-free

Hi Yuval,

On 03/22/2018 01:32 PM, Yuval Shaia wrote:
> On Thu, Mar 22, 2018 at 01:03:42PM -0500, Gustavo A. R. Silva wrote:
>> _rule_ is being freed and then dereferenced by accessing rule->ctx
>>
>> Fix this by copying the value returned by PTR_ERR(rule->ctx) into a local
>> variable for its safe use after freeing _rule_
>>
>> Addresses-Coverity-ID: 1466041 ("Read from pointer after free")
>> Fixes: 05564d0ae075 ("net/mlx5: Add flow-steering commands for FPGA IPSec implementation")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> 
> Prefix should not be that long, a short one as this is enough.
> 

Yeah. Actually, I was suspicious about it.

> net/mlx5: Fix use-after-free
> 
> Besides that - lgtm.
> 
> Reviewed-by: Yuval Shaia <yuval.shaia@...cle.com>
> 

I'll send v2 with a short prefix and add your Reviewed-by.

Thanks for the feedback.
--
Gustavo