linux-kernel - Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKywueS_8hhS3X=cCAD9etPr=L348kY3Wfv+n9q=gBV2ey6cbw@mail.gmail.com>
Date:   Thu, 22 Mar 2018 12:14:24 -0700
From:   Pavel Shilovsky <piastryyy@...il.com>
To:     "Srivatsa S. Bhat" <srivatsa@...il.mit.edu>
Cc:     Steve French <smfrench@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Backlund <tmb@...eia.org>,
        Aurélien Aptel <aaptel@...e.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Stable <stable@...r.kernel.org>,
        Ronnie Sahlberg <lsahlber@...hat.com>,
        Pavel Shilovskiy <pshilov@...rosoft.com>,
        CIFS <linux-cifs@...r.kernel.org>
Subject: Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always
 be signed

2018-03-21 22:12 GMT-07:00 Srivatsa S. Bhat <srivatsa@...il.mit.edu>:
> On 3/21/18 7:02 PM, Steve French wrote:
>> Found a patch which solves the dependency issue.  In my testing (on
>> 4.9, with Windows 2016, and also to Samba) as Pavel suggested this
>> appears to fix the problem, but I will let Srivatsa confirm that it
>> also fixes it for him.  The two attached patches for 4.9 should work.
>>
>
> Indeed, those two patches fix the problem for me on 4.9. Thanks a lot
> Steve, Pavel and Aurelien for all your efforts in fixing this!
>
> I was also interested in getting this fixed on 4.4, so I modified the
> patches to apply on 4.4.88 and verified that they fix the mount
> failure. I have attached my patches for 4.4 with this mail.
>
> Steve, Pavel, could you kindly double-check the second patch for 4.4,
> especially around the keygen_exit error path?

The patch looks good. Thanks for the backport.

--
Best regards,
Pavel Shilovsky