linux-kernel - Re: [PATCH] vfio-mdev/samples: change RDI interrupt condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180322154810.169b10af@w520.home>
Date:   Thu, 22 Mar 2018 15:48:10 -0600
From:   Alex Williamson <alex.williamson@...hat.com>
To:     Kirti Wankhede <kwankhede@...dia.com>
Cc:     Shunyong Yang <shunyong.yang@...-semitech.com>,
        <kvm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Joey Zheng <yu.zheng@...-semitech.com>
Subject: Re: [PATCH] vfio-mdev/samples: change RDI interrupt condition

On Fri, 9 Mar 2018 11:36:05 +0530
Kirti Wankhede <kwankhede@...dia.com> wrote:

> Thanks for fixing it.
> Patch looks good to me.
> +Alex to pull this patch.
> 
> Reviewed by: Kirti Wankhede <kwankhede@...dia.com>

Applied to vfio next branch for v4.17 with Kirti's Rb.  Thanks,

Alex

> On 3/8/2018 12:38 PM, Shunyong Yang wrote:
> > When FIFO mode is enabled, the receive data available interrupt
> > (UART_IIR_RDI in code) should be triggered when the number of data
> > in FIFO is equal or larger than interrupt trigger level.
> > 
> > This patch changes the trigger level check to ensure multiple bytes
> > received from upper layer can trigger RDI interrupt correctly.
> > 
> > Cc: Joey Zheng <yu.zheng@...-semitech.com>
> > Signed-off-by: Shunyong Yang <shunyong.yang@...-semitech.com>
> > ---
> >  samples/vfio-mdev/mtty.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-mdev/mtty.c
> > index 09f255bdf3ac..7abb79d8313d 100644
> > --- a/samples/vfio-mdev/mtty.c
> > +++ b/samples/vfio-mdev/mtty.c
> > @@ -534,7 +534,7 @@ static void handle_bar_read(unsigned int index, struct mdev_state *mdev_state,
> >  
> >  		/* Interrupt priority 2: Fifo trigger level reached */
> >  		if ((ier & UART_IER_RDI) &&
> > -		    (mdev_state->s[index].rxtx.count ==
> > +		    (mdev_state->s[index].rxtx.count >=
> >  		      mdev_state->s[index].intr_trigger_level))
> >  			*buf |= UART_IIR_RDI;
> >  
> >