linux-kernel - Re: [RFC PATCH] ftrace: support boot level tracing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180322192538.76164265@gandalf.local.home>
Date:   Thu, 22 Mar 2018 19:25:38 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Abderrahmane Benbachir <abderrahmane.benbachir@...ymtl.ca>
Cc:     mingo@...hat.com, peterz@...radead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] ftrace: support boot level tracing

On Tue, 20 Mar 2018 23:35:46 +0000
Abderrahmane Benbachir <abderrahmane.benbachir@...ymtl.ca> wrote:

> Steven Rostedt <rostedt@...dmis.org> a écrit :
> 
> > On Tue, 20 Mar 2018 14:22:56 -0400
> > Abderrahmane Benbachir <abderrahmane.benbachir@...ymtl.ca> wrote:
> >
> > Would something like this work for you?  
> 
> Yes this is working great. I have also instrumented console and security
> initcalls, I used your previous patch, changes are below.
> 
> > +	trace_initcall_level("pre_smp_initcalls");  
> 
> This should be "early" I guess : trace_initcall_level("ealry");

Hmm, I think I found an issue with what's there. I made up that name
because "early" was already taken.

> 
> 
> output of : trace_event=initcall_level
> 
> [    0.327032]   <idle>-0       0.... 89576us : initcall_level: level=console
> [    0.327454]   <idle>-0       0.... 135819us : initcall_level:  
> level=security
> [    0.327887] swapper/-1       0.... 261166us : initcall_level: level=early
> [    0.328306] swapper/-1       0.... 265248us : initcall_level: level=early

Noticed you have two "early"s.

The second early should be "pure". But that's an issue with init.c.

I'll apply mine (with minor updates) and add diffs by you. Care to give
me a "signed-off-by" for the console and security change.

-- Steve


> [    0.328742] swapper/-1       0.... 267969us : initcall_level: level=core
> [    0.329158] swapper/-1       0.... 270111us : initcall_level:  
> level=postcore
> [    0.329590] swapper/-1       0.... 271111us : initcall_level: level=arch
> [    0.330007] swapper/-1       0.... 272217us : initcall_level: level=subsys
> [    0.330429] swapper/-1       0.... 316236us : initcall_level: level=fs
> [    0.330833] swapper/-1       0.... 340523us : initcall_level: level=device
> [    0.331254] swapper/-1       0.... 388737us : initcall_level: level=late
> 
> PATCH with security and console instrumented
> 
>