linux-kernel - Re: [PATCH] tty/nozomi: refactor macros and functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180323152737.GA25972@kroah.com>
Date:   Fri, 23 Mar 2018 16:27:37 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Joey Pabalinas <joeypabalinas@...il.com>
Cc:     linux-kernel@...r.kernel.org, Frank Seidel <fseidel@...e.de>,
        Arnd Bergmann <arnd@...db.de>, Jiri Slaby <jslaby@...e.cz>
Subject: Re: [PATCH] tty/nozomi: refactor macros and functions

On Tue, Mar 20, 2018 at 06:34:30PM -1000, Joey Pabalinas wrote:
> Cleanup a few messy sections of code by replacing constructs
> like `len__ > TMP_BUF_MAX ? TMP_BUF_MAX : len__` with
> `min_t(u32, len__, TMP_BUF_MAX)` and naming identifiers
> more descriptively (where appropriate).
> 
> A few sections were nested pretty deeply and have been
> replaced with shallower (but semantically equivalent) logic.
> 
> In addition, simplify and coalesce a few of the
> return paths / loop conditionals and correct a few
> pointless Initializations, redundant parentheses/break
> statements, and inconsistently indented line.

That's a lot of different things to do all in a single patch.

Please break this up into a patch series, doing only one logical "thing"
per patch.

thanks,

greg k-h