linux-kernel - Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180323154654.GA382@kroah.com>
Date:   Fri, 23 Mar 2018 16:46:54 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Ioana Ciornei <ioana.ciornei@....com>
Cc:     laurentiu.tudor@....com, linux-kernel@...r.kernel.org,
        stuyoder@...il.com, ruxandra.radulescu@....com, arnd@...db.de,
        razvan.stefanescu@....com, Roy.Pledge@....com
Subject: Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

On Fri, Mar 23, 2018 at 10:38:56AM -0500, Ioana Ciornei wrote:
> +#include "fsl-mc-private.h"
> +
> +#define FSL_MC_BUS_MAX_MINORS	1

As you only need/want one character device here, why not just use the
misc device api?  It's much simpler, and handles all of the housekeeping
for you correctly.  It also means I don't have to audit all of your
chardev code to verify it is correct :)

And it will save you lines-of-code, always a good thing.

thanks,

greg k-h