linux-kernel - RE: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <HE1PR04MB32123F0FF506534B11A1CE5BE0A80@HE1PR04MB3212.eurprd04.prod.outlook.com>
Date:   Fri, 23 Mar 2018 15:56:24 +0000
From:   Ioana Ciornei <ioana.ciornei@....com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     Laurentiu Tudor <laurentiu.tudor@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stuyoder@...il.com" <stuyoder@...il.com>,
        Ruxandra Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>,
        "arnd@...db.de" <arnd@...db.de>,
        Razvan Stefanescu <razvan.stefanescu@....com>,
        Roy Pledge <roy.pledge@....com>
Subject: RE: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support


> 
> On Fri, Mar 23, 2018 at 10:38:56AM -0500, Ioana Ciornei wrote:
> > +#include "fsl-mc-private.h"
> > +
> > +#define FSL_MC_BUS_MAX_MINORS	1
> 
> As you only need/want one character device here, why not just use the misc
> device api?  It's much simpler, and handles all of the housekeeping for you
> correctly.  It also means I don't have to audit all of your chardev code to verify it
> is correct :)

I have considered the misc device api but the fsl-mc bus, since it is a platform driver, is probing before the misc char driver.

Ioana


> 
> And it will save you lines-of-code, always a good thing.
> 
> thanks,
> 
> greg k-h