[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VeTxGu-pxqde_egsqUkLBdZujoJv=0YEj9cv8ujnthyPA@mail.gmail.com>
Date:   Fri, 23 Mar 2018 18:31:05 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Timur Tabi <timur@...eaurora.org>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm-msm@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Grant Likely <grant.likely@...retlab.ca>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH v3 3/3] pinctrl: qcom: Don't allow protected pins to be requested
On Fri, Mar 23, 2018 at 6:21 PM, Stephen Boyd <swboyd@...omium.org> wrote:
>        bitmap_zero(chip->valid_mask, max_gpios);
>        for (i = 0; i < len; i++)
>                set_bit(tmp[i], chip->valid_mask);
Looking to this code I just realized it would be nice to have
{of,device}_property_read_bitmask() where bitmask_parse() is called.
Since it related to change a binding, I would really take couple of
days to hear other opinions.
In the above case, you need to supply a string, like
"1-5,16,18,25"
-- 
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists
 
