linux-kernel - Re: [PATCH v3] ata: add Amiga Gayle PATA controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOFm3uE1UxeW-dPyFEzr5BiaWp6wLiJ4Z8X3qcH8Crr=b4nLWA@mail.gmail.com>
Date:   Fri, 23 Mar 2018 10:10:30 -0700
From:   Philippe Ombredanne <pombredanne@...b.com>
To:     Tejun Heo <tj@...nel.org>
Cc:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
        Michael Schmitz <schmitzmic@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        linux-ide@...r.kernel.org, linux-m68k@...ts.linux-m68k.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] ata: add Amiga Gayle PATA controller driver

Tejun,

On Mon, Mar 19, 2018 at 7:41 AM, Tejun Heo <tj@...nel.org> wrote:
> Hello,
>
> On Sat, Mar 17, 2018 at 10:24:18PM -0700, Philippe Ombredanne wrote:
>> > v2:
>> > - clarify license version (it should be GPL 2.0)
>> > - use SPDX header
>>
>> For the use of SPDX ids, you have my ack: (I am not qualified for the rest)
>>
>> Acked-by: Philippe Ombredanne <pombredanne@...b.com>
>
> I don't think it's a good idea to add this acked-by when it's purely
> based on a single liner license tag.  I understand that you want to
> encourage use of the new tags but this can be misleading and it'd be
> great if you reconsider sending out acks like this.
>
> Thanks.


You have a good point. I find it confusing myself.
Please, remove this ack!

-- 
Cordially
Philippe Ombredanne