linux-kernel - Re: [PATCH 09/11] x86/pti: enable global pages for shared areas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f97f448-307f-1095-84cc-1b7444eb78a8@linux.intel.com>
Date:   Fri, 23 Mar 2018 12:36:58 -0700
From:   Dave Hansen <dave.hansen@...ux.intel.com>
To:     Nadav Amit <namit@...are.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "aarcange@...hat.com" <aarcange@...hat.com>,
        "luto@...nel.org" <luto@...nel.org>,
        "torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
        "keescook@...gle.com" <keescook@...gle.com>,
        "hughd@...gle.com" <hughd@...gle.com>,
        "jgross@...e.com" <jgross@...e.com>,
        "x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH 09/11] x86/pti: enable global pages for shared areas

On 03/23/2018 12:12 PM, Nadav Amit wrote:
>> 		/*
>> +		 * Setting 'target_pmd' below creates a mapping in both
>> +		 * the user and kernel page tables.  It is effectively
>> +		 * global, so set it as global in both copies.
>> +		 */
>> +		*pmd = pmd_set_flags(*pmd, _PAGE_GLOBAL);
> if (boot_cpu_has(X86_FEATURE_PGE)) ?

Good catch.  I'll update that.