linux-kernel - Re: [PATCH v1 0/4] platform/x86: mlx-platform: Add bus differed and auto detection functionalities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180323230920.GE17520@fury>
Date:   Fri, 23 Mar 2018 16:09:20 -0700
From:   Darren Hart <dvhart@...radead.org>
To:     Vadim Pasternak <vadimp@...lanox.com>
Cc:     "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        Michael Shych <michaelsh@...lanox.com>
Subject: Re: [PATCH v1 0/4] platform/x86: mlx-platform: Add bus differed and
 auto detection functionalities

On Fri, Mar 23, 2018 at 03:59:22PM +0000, Vadim Pasternak wrote:
> 
> 
> > -----Original Message-----
> > From: Darren Hart [mailto:dvhart@...radead.org]
> > Sent: Friday, March 23, 2018 1:56 AM
> > To: Vadim Pasternak <vadimp@...lanox.com>
> > Cc: andy.shevchenko@...il.com; gregkh@...uxfoundation.org; platform-
> > driver-x86@...r.kernel.org; linux-kernel@...r.kernel.org; jiri@...nulli.us;
> > Michael Shych <michaelsh@...lanox.com>
> > Subject: Re: [PATCH v1 0/4] platform/x86: mlx-platform: Add bus differed and
> > auto detection functionalities
> > 
> > On Tue, Feb 13, 2018 at 10:09:32PM +0000, Vadim Pasternak wrote:
> > > This patchset:
> > > - Adds define for the channels number for mux device.
> > > - Adds differed bus functionality.
> > > - Changes input for device create routine in mlxreg-hotplug driver.
> > > - Adds physical bus number auto detection.
> > >
> > > Vadim Pasternak (4):
> > >   platform/x86: mlx-platform: Use define for the channel numbers
> > >   platform/x86: mlx-platform: Add differed bus functionality
> > >   platform/mellanox: mlxreg-hotplug: Change input for device create
> > >     routine
> > >   platform/x86: mlx-platform: Add physical bus number auto detection
> > 
> > Vadim,
> > 
> > I have rewritten most of the commit messages after parsing through them and
> > reviewing the code. I believe they are much more concise now, and make the
> > intent of the patches much clearer. I have not changed the patch content (code).
> > 
> > Please review the commit messages for the top 4 commits:
> > http://git.infradead.org/linux-platform-drivers-
> > x86.git/shortlog/refs/heads/review-dvhart-mellanox
> > 
> > Does this still match your intent?
> > 
> 
> Hi Darren,
> Thank you very much for review.
> 
> Looks good.

Thanks Vadim. I have queued these plus the Kconfig build dep fix for 4.17.

-- 
Darren Hart
VMware Open Source Technology Center