linux-kernel - Re: [PATCH v2] venus: vdec: fix format enumeration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3f82e52d-7e5e-4184-ea36-e76d924ab00c@linaro.org>
Date:   Sat, 24 Mar 2018 01:54:18 +0200
From:   Stanimir Varbanov <stanimir.varbanov@...aro.org>
To:     Hans Verkuil <hverkuil@...all.nl>
Cc:     Alexandre Courbot <acourbot@...omium.org>,
        linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] venus: vdec: fix format enumeration

Hi Hans,

Could you take this patch it not too late.

On 20.03.2018 15:42, Stanimir Varbanov wrote:
> Hi Alex,
> 
> Thanks!
> 
> On 03/19/2018 11:32 AM, Alexandre Courbot wrote:
>> find_format_by_index() stops enumerating formats as soon as the index
>> matches, and returns NULL if venus_helper_check_codec() finds out that
>> the format is not supported. This prevents formats to be properly
>> enumerated if a non-supported format is present, as the enumeration will
>> end with it.
>>
>> Fix this by moving the call to venus_helper_check_codec() into the loop,
>> and keep enumerating when it fails.
>>
>> Fixes: 29f0133ec6 media: venus: use helper function to check supported codecs
>>
>> Signed-off-by: Alexandre Courbot <acourbot@...omium.org>
>> ---
>>   drivers/media/platform/qcom/venus/vdec.c | 13 +++++++------
>>   drivers/media/platform/qcom/venus/venc.c | 13 +++++++------
>>   2 files changed, 14 insertions(+), 12 deletions(-)
> 
> Acked-by: Stanimir Varbanov <stanimir.varbanov@...aro.org>
> 

regards,
Stan