linux-kernel - Re: [PATCH 0/2] bpf: Change print_bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f5586965-1447-ba8e-a27c-398b221f18e3@netronome.com>
Date:   Fri, 23 Mar 2018 13:34:19 +0000
From:   Quentin Monnet <quentin.monnet@...ronome.com>
To:     Jiri Olsa <jolsa@...nel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>
Cc:     lkml <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH 0/2] bpf: Change print_bpf_insn interface

2018-03-23 11:41 UTC+0100 ~ Jiri Olsa <jolsa@...nel.org>
> hi,
> this patchset removes struct bpf_verifier_env argument
> from print_bpf_insn function (patch 1) and changes user
> space bpftool user to use it that way (patch 2).
> 
> thanks,
> jirka
> 
> ---
> Jiri Olsa (2):
>       bpf: Remove struct bpf_verifier_env argument from print_bpf_insn
>       bpftool: Adjust to new print_bpf_insn interface
> 
>  kernel/bpf/disasm.c               | 52 ++++++++++++++++++++++++++--------------------------
>  kernel/bpf/disasm.h               |  5 +----
>  kernel/bpf/verifier.c             | 44 +++++++++++++++++++++++++++-----------------
>  tools/bpf/bpftool/xlated_dumper.c | 12 ++++++------
>  4 files changed, 60 insertions(+), 53 deletions(-)
> 

Thanks, this version looks good to me. Please keep the "Reviewed-by"
tags when resubmitting new versions of your patch sets :)

For the series:
Reviewed-by: Quentin Monnet <quentin.monnet@...ronome.com>