linux-kernel - Re: [PATCH v2 2/6] bus: fsl-mc: move fsl_mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180323141932.GA28906@kroah.com>
Date:   Fri, 23 Mar 2018 15:19:32 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Ioana Ciornei <ioana.ciornei@....com>
Cc:     laurentiu.tudor@....com, linux-kernel@...r.kernel.org,
        stuyoder@...il.com, ruxandra.radulescu@....com,
        razvan.stefanescu@....com, Roy.Pledge@....com, arnd@...db.de
Subject: Re: [PATCH v2 2/6] bus: fsl-mc: move fsl_mc_command struct in a uapi
 header

On Thu, Mar 15, 2018 at 12:05:32PM -0500, Ioana Ciornei wrote:
> Define "struct fsl_mc_command" as a structure that can cross the
> user/kernel boundary. Also change the variable types used with
> the proper ones.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> ---
> Changes in v2:
>   - added the patch itself
> 
>  MAINTAINERS                 |  1 +
>  include/linux/fsl/mc.h      |  8 +-------
>  include/uapi/linux/fsl_mc.h | 23 +++++++++++++++++++++++
>  3 files changed, 25 insertions(+), 7 deletions(-)
>  create mode 100644 include/uapi/linux/fsl_mc.h
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 473ac00..4f54765 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11463,6 +11463,7 @@ S:	Maintained
>  F:	drivers/bus/fsl-mc/
>  F:	Documentation/devicetree/bindings/misc/fsl,qoriq-mc.txt
>  F:	Documentation/networking/dpaa2/overview.rst
> +F:	include/uapi/linux/fsl_mc.h
>  
>  QT1010 MEDIA DRIVER
>  M:	Antti Palosaari <crope@....fi>
> diff --git a/include/linux/fsl/mc.h b/include/linux/fsl/mc.h
> index f27cb14..19a352b 100644
> --- a/include/linux/fsl/mc.h
> +++ b/include/linux/fsl/mc.h
> @@ -12,6 +12,7 @@
>  #include <linux/device.h>
>  #include <linux/mod_devicetable.h>
>  #include <linux/interrupt.h>
> +#include <uapi/linux/fsl_mc.h>
>  
>  #define FSL_MC_VENDOR_FREESCALE	0x1957
>  
> @@ -198,8 +199,6 @@ struct fsl_mc_device {
>  #define to_fsl_mc_device(_dev) \
>  	container_of(_dev, struct fsl_mc_device, dev)
>  
> -#define MC_CMD_NUM_OF_PARAMS	7
> -
>  struct mc_cmd_header {
>  	u8 src_id;
>  	u8 flags_hw;
> @@ -209,11 +208,6 @@ struct mc_cmd_header {
>  	__le16 cmd_id;
>  };
>  
> -struct fsl_mc_command {
> -	u64 header;
> -	u64 params[MC_CMD_NUM_OF_PARAMS];
> -};
> -
>  enum mc_cmd_status {
>  	MC_CMD_STATUS_OK = 0x0, /* Completed successfully */
>  	MC_CMD_STATUS_READY = 0x1, /* Ready to be processed */
> diff --git a/include/uapi/linux/fsl_mc.h b/include/uapi/linux/fsl_mc.h
> new file mode 100644
> index 0000000..90892c4
> --- /dev/null
> +++ b/include/uapi/linux/fsl_mc.h
> @@ -0,0 +1,23 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

UAPI files should have the correct license on them:
	/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */

thanks,

greg k-h