linux-kernel - Re: [PATCH] drm/msm/dsi: use correct enum in dsi_get_cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46b36451-8b2c-fdb4-16b3-64a52cb80954@codeaurora.org>
Date:   Sat, 24 Mar 2018 17:07:42 +0530
From:   Archit Taneja <architt@...eaurora.org>
To:     Stefan Agner <stefan@...er.ch>, robdclark@...il.com,
        airlied@...ux.ie
Cc:     seanpaul@...omium.org, ssusheel@...eaurora.org, robh@...nel.org,
        linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/msm/dsi: use correct enum in dsi_get_cmd_fmt



On Tuesday 20 March 2018 02:56 AM, Stefan Agner wrote:
> The function dsi_get_cmd_fmt returns enum dsi_cmd_dst_format,
> use the correct enum value also for MIPI_DSI_FMT_RGB666/_PACKED.
> 
> This has been discovered using clang:
>    drivers/gpu/drm/msm/dsi/dsi_host.c:743:35: warning: implicit conversion
>          from enumeration type 'enum dsi_vid_dst_format' to different
>          enumeration type 'enum dsi_cmd_dst_format' [-Wenum-conversion]
>            case MIPI_DSI_FMT_RGB666:       return VID_DST_FORMAT_RGB666;
>                                            ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Stefan Agner <stefan@...er.ch>

Reviewed-by: Archit Taneja <architt@...eaurora.org>

Archit

> ---
>   drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index 0f7324a686ca..d729b2b4b66d 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -740,7 +740,7 @@ static inline enum dsi_cmd_dst_format dsi_get_cmd_fmt(
>   	switch (mipi_fmt) {
>   	case MIPI_DSI_FMT_RGB888:	return CMD_DST_FORMAT_RGB888;
>   	case MIPI_DSI_FMT_RGB666_PACKED:
> -	case MIPI_DSI_FMT_RGB666:	return VID_DST_FORMAT_RGB666;
> +	case MIPI_DSI_FMT_RGB666:	return CMD_DST_FORMAT_RGB666;
>   	case MIPI_DSI_FMT_RGB565:	return CMD_DST_FORMAT_RGB565;
>   	default:			return CMD_DST_FORMAT_RGB888;
>   	}
>