linux-kernel - Re: [PATCH 14/19] powerpc/altivec: Add missing prototypes for altivec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 24 Mar 2018 21:10:20 +0100
From:   LEROY Christophe <christophe.leroy@....fr>
To:     Mathieu Malaterre <malat@...ian.org>
Cc:     linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        Paul Mackerras <paulus@...ba.org>, kvm-ppc@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Michael Ellerman <mpe@...erman.id.au>
Subject: Re: [PATCH 14/19] powerpc/altivec: Add missing prototypes for
 altivec

Mathieu Malaterre <malat@...ian.org> a écrit :

> On Fri, Mar 23, 2018 at 1:19 PM, christophe leroy
> <christophe.leroy@....fr> wrote:
>>
>>
>> Le 22/03/2018 à 21:20, Mathieu Malaterre a écrit :
>>>
>>> Some functions prototypes were missing for the non-altivec code. Add the
>>> missing prototypes directly in xor_vmx, fix warnings treated as errors
>>> with
>>> W=1:
>>>
>>>    arch/powerpc/lib/xor_vmx_glue.c:18:6: error: no previous prototype for
>>> ‘xor_altivec_2’ [-Werror=missing-prototypes]
>>>    arch/powerpc/lib/xor_vmx_glue.c:29:6: error: no previous prototype for
>>> ‘xor_altivec_3’ [-Werror=missing-prototypes]
>>>    arch/powerpc/lib/xor_vmx_glue.c:40:6: error: no previous prototype for
>>> ‘xor_altivec_4’ [-Werror=missing-prototypes]
>>>    arch/powerpc/lib/xor_vmx_glue.c:52:6: error: no previous prototype for
>>> ‘xor_altivec_5’ [-Werror=missing-prototypes]
>>>
>>> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
>>> ---
>>>   arch/powerpc/lib/xor_vmx.h | 14 ++++++++++++++
>>>   1 file changed, 14 insertions(+)
>>>
>>> diff --git a/arch/powerpc/lib/xor_vmx.h b/arch/powerpc/lib/xor_vmx.h
>>> index 5c2b0839b179..2173e3c84151 100644
>>> --- a/arch/powerpc/lib/xor_vmx.h
>>> +++ b/arch/powerpc/lib/xor_vmx.h
>>> @@ -19,3 +19,17 @@ void __xor_altivec_4(unsigned long bytes, unsigned long
>>> *v1_in,
>>>   void __xor_altivec_5(unsigned long bytes, unsigned long *v1_in,
>>>                              unsigned long *v2_in, unsigned long *v3_in,
>>>                              unsigned long *v4_in, unsigned long *v5_in);
>>> +
>>> +void xor_altivec_2(unsigned long bytes, unsigned long *v1_in,
>>> +                            unsigned long *v2_in);
>>> +
>>
>>
>> Only used in one place, should be static instead of adding it in a .h
>>
>> Same for the other ones.
>
> $ git grep xor_altivec_2
> [...]
> arch/powerpc/lib/xor_vmx_glue.c:EXPORT_SYMBOL(xor_altivec_2);
>
> Are you sure I can change this function to static ?

Yes you are right.  But in fact those fonctions are already defined in  
asm/xor. h
So you just need to add the missing #include

Christophe

>
>> Christophe
>>
>>
>>> +void xor_altivec_3(unsigned long bytes, unsigned long *v1_in,
>>> +                            unsigned long *v2_in, unsigned long *v3_in);
>>> +
>>> +void xor_altivec_4(unsigned long bytes, unsigned long *v1_in,
>>> +                            unsigned long *v2_in, unsigned long *v3_in,
>>> +                            unsigned long *v4_in);
>>> +
>>> +void xor_altivec_5(unsigned long bytes, unsigned long *v1_in,
>>> +                            unsigned long *v2_in, unsigned long *v3_in,
>>> +                            unsigned long *v4_in, unsigned long *v5_in);
>>>
>>
>> ---
>> L'absence de virus dans ce courrier électronique a été vérifiée par le
>> logiciel antivirus Avast.
>> https://www.avast.com/antivirus
>>