linux-kernel - Re: [PATCH 01/16] initrd: Add generic code path for common initrd unloading logic.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r2o7u7al.fsf@xps13.shealevy.com>
Date:   Sun, 25 Mar 2018 18:20:02 -0400
From:   Shea Levy <shea@...alevy.com>
To:     LEROY Christophe <christophe.leroy@....fr>
Cc:     user-mode-linux-devel@...ts.sourceforge.net,
        linux-sh@...r.kernel.org, linux-riscv@...ts.infradead.org,
        linuxppc-dev@...ts.ozlabs.org, linux-parisc@...r.kernel.org,
        openrisc@...ts.librecores.org, nios2-dev@...ts.rocketboards.org,
        linux-m68k@...ts.linux-m68k.org,
        uclinux-h8-devel@...ts.sourceforge.jp, linux-c6x-dev@...ux-c6x.org,
        linux-snps-arc@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-alpha@...r.kernel.org
Subject: Re: [PATCH 01/16] initrd: Add generic code path for common initrd unloading logic.

Hi Christophe,

LEROY Christophe <christophe.leroy@....fr> writes:

> Shea Levy <shea@...alevy.com> a écrit :
>
>> Signed-off-by: Shea Levy <shea@...alevy.com>
>> ---
>>  init/initramfs.c | 7 +++++++
>>  usr/Kconfig      | 4 ++++
>>  2 files changed, 11 insertions(+)
>>
>> diff --git a/init/initramfs.c b/init/initramfs.c
>> index 7e99a0038942..de5ce873eb5a 100644
>> --- a/init/initramfs.c
>> +++ b/init/initramfs.c
>> @@ -526,6 +526,13 @@ extern unsigned long __initramfs_size;
>>  #include <linux/initrd.h>
>>  #include <linux/kexec.h>
>>
>> +#ifdef CONFIG_INITRAMFS_GENERIC_UNLOAD
>> +void free_initrd_mem(unsigned long start, unsigned long end)
>> +{
>> +       free_reserved_area((void *)start, (void *)end, -1, "initrd");
>> +}
>> +#endif
>
> In powerpc this was an __init function. Why not also put the generic  
> one in __init section ?
>

v2 series sent, thanks!

>
> Christophe
>
>
>> +
>>  static void __init free_initrd(void)
>>  {
>>  #ifdef CONFIG_KEXEC_CORE
>> diff --git a/usr/Kconfig b/usr/Kconfig
>> index 43658b8a975e..fd79d4d6fa26 100644
>> --- a/usr/Kconfig
>> +++ b/usr/Kconfig
>> @@ -233,3 +233,7 @@ config INITRAMFS_COMPRESSION
>>  	default ".lzma" if RD_LZMA
>>  	default ".bz2"  if RD_BZIP2
>>  	default ""
>> +
>> +# Arches can select this for a generic initrd unloading codepath
>> +config INITRAMFS_GENERIC_UNLOAD
>> +	bool
>> --
>> 2.16.2

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)