linux-kernel - Re: [PATCH] genirq: Pass desc to __irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Mar 2018 11:43:27 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
cc:     linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH] genirq: Pass desc to __irq_free instead of irq number

On Mon, 26 Mar 2018, Uwe Kleine-König wrote:
> 
> On Mon, Mar 19, 2018 at 11:52:02AM +0100, Uwe Kleine-König wrote:
> > Given that irq_to_desc() is a radix_tree_lookup and the reverse
> > operation is only a pointer dereference and that all callers of
> > __free_irq already have the desc, pass the desc instead of the irq
> > number.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > ---
> > Hello,
> > 
> > this is a micro optimisation I noticed while looking at the irq code.
> 
> This made it into next as 83ac4ca943affce56a2c408ddb2f5232f478fb11 and
> ba63053f018721a0ad60b083e21a15e324a4a8c4. Is it right that it is there
> twice?

No. It's only one instance.

> And in the Author line the - in my name is missing. Would be great if
> that could be fixed up.

Sorry, I'm surely not rebasing that branch just to add a missing dash.

Thanks,

	tglx