linux-kernel - Re: [PATCH]cgroup: __cpuset_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180326141212.GI2149215@devbig577.frc2.facebook.com>
Date:   Mon, 26 Mar 2018 07:12:12 -0700
From:   Tejun Heo <tj@...nel.org>
To:     yuankuiz@...eaurora.org
Cc:     cgroups@...r.kernel.org, lizefan@...wei.com, hannes@...xchg.org,
        linux-kernel@...r.kernel.org, pkondeti@...eaurora.org,
        cgroups-owner@...r.kernel.org
Subject: Re: [PATCH]cgroup: __cpuset_node_allowed return bool

Hello, John.

On Sat, Mar 24, 2018 at 01:05:50PM +0800, yuankuiz@...eaurora.org wrote:
> From 304cec1cc42255fbd9e231a810f4eea20ab74b90 Mon Sep 17 00:00:00 2001
> From: John Zhao <yuankuiz@...eaurora.org>
> Date: Sat, 24 Mar 2018 13:01:32 +0800
> Subject: [PATCH] cgroup: __cpuset_node_allowed return bool
> 
> as a bool, __cpuset_node_allowed(...) return should be bool.

So, as a minor cleanup patch, this is fine but can you please soften
the commit title / description a bit?  It doesn't have to be bool.
int is fine.  bool may be marginally more readable but that's about
it, so let's please make the commit match that.

Thanks.

-- 
tejun