linux-kernel - Re: [PATCH 1/3] kconfig: remove duplicated file name and lineno of recursive inclusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNASaHvmxHn4PiCO7bs+WfmoeBfpKR+zZBrXQFn+LEu7b1A@mail.gmail.com>
Date:   Tue, 27 Mar 2018 00:24:27 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>
Cc:     Michal Marek <michal.lkml@...kovi.net>,
        Sam Ravnborg <sam@...nborg.org>,
        Ulf Magnusson <ulfalizer@...il.com>,
        "Luis R . Rodriguez" <mcgrof@...nel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] kconfig: remove duplicated file name and lineno of
 recursive inclusion

2018-03-23 2:00 GMT+09:00 Masahiro Yamada <yamada.masahiro@...ionext.com>:
> As in the unit test, the error message for the recursive inclusion
> looks like this:
>
>   Kconfig.inc1:4: recursive inclusion detected. Inclusion path:
>     current file : 'Kconfig.inc1'
>     included from: 'Kconfig.inc3:1'
>     included from: 'Kconfig.inc2:3'
>     included from: 'Kconfig.inc1:4'
>
> The 'Kconfig.inc1:4' is duplicated in the first and last lines.
> Also, the single quotes do not help readability.
>
> Change the message like follows:
>
>   Recursive inclusion detected.
>   Inclusion path:
>     current file : Kconfig.inc1
>     included from: Kconfig.inc3:1
>     included from: Kconfig.inc2:3
>     included from: Kconfig.inc1:4
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---

Applied to linux-kbuild/kconfig.




-- 
Best Regards
Masahiro Yamada