linux-kernel - Re: [PATCH RT] Defer migrate_enable migration while task state != TASK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180326115904.492a3bad@gandalf.local.home>
Date:   Mon, 26 Mar 2018 11:59:04 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     joe.korty@...current-rt.com
Cc:     Julia Cartwright <julia@...com>, <bigeasy@...utronix.de>,
        <mingo@...hat.com>, <tglx@...utronix.de>,
        <linux-rt-users@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RT] Defer migrate_enable migration while task state !=
 TASK_RUNNING

On Mon, 26 Mar 2018 11:54:51 -0400
joe.korty@...current-rt.com wrote:

> Oh well.  Makes me wonder why might_sleep is testing for
> !TASK_RUNNABLE though.

Because might_sleep() is used when the function might call schedule()
directly. And schedule() *will* change the task state to TASK_RUNNING.
might_sleep() has nothing to do with preemption.

-- Steve