linux-kernel - Re: [PATCH v3] scsi: ufs: add trace event for ufs upiu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1522104532.3102.24.camel@wdc.com>
Date:   Mon, 26 Mar 2018 22:48:53 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     Ohad Sharabi <Ohad.Sharabi@....com>,
        "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        Stanislav Nijnikov <Stanislav.Nijnikov@....com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Alex Lemberg <Alex.Lemberg@....com>
Subject: Re: [PATCH v3] scsi: ufs: add trace event for ufs upiu

On Sun, 2018-03-25 at 10:08 +0300, Ohad Sharabi wrote:
> Add UFS Protocol Information Units(upiu) trace events for ufs driver,
> used to trace various ufs transaction types- command, task-management
> and device management.
> The trace-point format is generic and can be easily adapted to trace
> other upius if needed.
> Currently tracing ufs transaction of type 'device management', which
> this patch introduce, cannot be obtained from any other trace.
> Device management transactions are used for communication with the
> device such as reading and writing descriptor or attributes etc.
> 
> v2->v3:
>     - modify args 3,4 of trace_ufshcd_upiu to be void *
> 
> v1->v2:
>     - split to transaction specific functions (fix warnings and simplifies
>       code)
>     - adding traces when sending query command

The changelog for a patch should appear under the three hyphens such that it
gets discarded automatically by tools like "git am". Martin will have to
remove the above changelog manually. Anyway:

Reviewed-by: Bart Van Assche <bart.vanassche@....com>