linux-kernel - Re: [PATCH v3 2/6] phy: qcom-qusb2: Fix crash if nvmem cell not specified

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE=gft67HuudBajKESOgZtgMz7owJqdoYPJp_6LpyB37a0-iYQ@mail.gmail.com>
Date:   Tue, 27 Mar 2018 17:35:02 +0000
From:   Evan Green <evgreen@...omium.org>
To:     Manu Gautam <mgautam@...eaurora.org>
Cc:     kishon@...com, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, robh+dt@...nel.org,
        linux-arm-msm@...r.kernel.org, stable@...r.kernel.org,
        vivek.gautam@...eaurora.org, jh80.chung@...sung.com,
        yoshihiro.shimoda.uh@...esas.com
Subject: Re: [PATCH v3 2/6] phy: qcom-qusb2: Fix crash if nvmem cell not specified

On Thu, Mar 22, 2018 at 11:13 PM Manu Gautam <mgautam@...eaurora.org> wrote:

> Driver currently crashes due to NULL pointer deference
> while updating PHY tune register if nvmem cell is NULL.
> Since, fused value for Tune1/2 register is optional,
> we'd rather bail out.

> Fixes: ca04d9d3e1b1 ("phy: qcom-qusb2: New driver for QUSB2 PHY on Qcom
chips")
> Reviewed-by: Vivek Gautam <vivek.gautam@...eaurora.org>
> Cc: stable <stable@...r.kernel.org> # 4.14+
> Signed-off-by: Manu Gautam <mgautam@...eaurora.org>
> ---
>   drivers/phy/qualcomm/phy-qcom-qusb2.c | 4 ++++
>   1 file changed, 4 insertions(+)


Reviewed-by: Evan Green <evgreen@...omium.org>