linux-kernel - Re: [PATCH v2 1/4] selftests/Makefile: append a slash to env variable OUTPUT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b473e652-0953-63ec-c4bf-5c9306dc4f67@kernel.org>
Date:   Tue, 27 Mar 2018 15:19:26 -0600
From:   Shuah Khan <shuah@...nel.org>
To:     changbin.du@...el.com
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <shuahkh@....samsung.com>,
        Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH v2 1/4] selftests/Makefile: append a slash to env variable
 OUTPUT

On 03/26/2018 09:11 PM, changbin.du@...el.com wrote:
> From: Changbin Du <changbin.du@...el.com>
> 
> The tools/build/Makefile.build use 'OUTPUT' variable as below example:
> objprefix    := $(subst ./,,$(OUTPUT)$(dir)/)
> 
> So it requires the 'OUTPUT' already has a slash at the end.
> 
> This patch can kill below odd paths:
> make[3]: Entering directory '/home/changbin/work/linux/tools/gpio'
>   CC       /home/changbin/work/linux/tools/testing/selftests/gpiolsgpio.o
>   CC       /home/changbin/work/linux/tools/testing/selftests/gpiogpio-utils.o
>   LD       /home/changbin/work/linux/tools/testing/selftests/gpiolsgpio-in.o
> 
> A correct path should be:
> /home/changbin/work/linux/tools/testing/selftests/gpio/lsgpio.o
> 
> Signed-off-by: Changbin Du <changbin.du@...el.com>

Are you seeing this when you run "make kselftest" - if gpio is the
only test compile that fails, it should be fixed in gpio/Makefile,
not is the common Makefile.

thanks,
-- Shuah