linux-kernel - Re: [PATCH v3 0/1] can: ucan: add driver for Theobroma Systems UCAN devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb761460-791f-023f-eabb-9b5610bfb6a6@theobroma-systems.com>
Date:   Tue, 27 Mar 2018 12:19:37 +0200
From:   Martin Elshuber <martin.elshuber@...obroma-systems.com>
To:     Jakob Unterwurzacher <jakob.unterwurzacher@...obroma-systems.com>,
        Wolfgang Grandegger <wg@...ndegger.com>
Cc:     Philipp Tomsich <philipp.tomsich@...obroma-systems.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        linux-can@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/1] can: ucan: add driver for Theobroma Systems UCAN
 devices

Where possible we changed dev_XXX to netdev_XXX. and removed all __func__.
netdev_XXX prints the necessary information on the device, bus and netif
The remaining dev_XXX (within probe) are extended such that they print
the string "ucan" (__func__ are also removed)

Am 23.03.18 um 11:12 schrieb Jakob Unterwurzacher:
> On 23.03.18 11:04, Wolfgang Grandegger wrote:
>>
>>> But I'm open to other suggestions (use a fixed "ucan: " prefix?) or to
>>> drop it entirely if you think it is not worth it.
>>
>> But there is already a device prefix, e.g.:
>>
>>    peak_usb 1-6:1.0: PEAK-System PCAN-USB adapter hwrev 28 serial
>> FFFFFFFF (1 channel)
>>    peak_usb 1-6:1.0 can0: attached to PCAN-USB channel 0 (device 255)
>>    ^^^^^^^^
>
> Interesting. Looks like the UCAN driver is missing something to make
> this work:
>
> [   67.792947] usb 5-1.4: ucan_probe: registered UCAN device at can0
>
> I'll take a closer look.
>
> Thanks,
> Jakob

-- 
Martin Elshuber
Theobroma Systems Design und Consulting GmbH
Seestadtstraße 27 (Aspern IQ), 1220 Wien, Austria
Phone: +43 1 236 98 93-405, Fax: +43 1 236 98 93-9
http://www.theobroma-systems.com




Download attachment "signature.asc" of type "application/pgp-signature" (843 bytes)