linux-kernel - Re: [PATCH v2] gpio: ath79: Fix potential NULL dereference in ath79_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdaqeOccK_a0foGRwLbi_ATaRrD7eA=wGcV3QUZarRfGCw@mail.gmail.com>
Date:   Tue, 27 Mar 2018 15:43:00 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Alban Bedel <albeu@...e.fr>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] gpio: ath79: Fix potential NULL dereference in ath79_gpio_probe()

On Sun, Mar 25, 2018 at 12:40 AM, Alban Bedel <albeu@...e.fr> wrote:

> From: Wei Yongjun <weiyongjun1@...wei.com>
>
> platform_get_resource() may return NULL, add proper
> check to avoid potential NULL dereferencing.
>
> This is detected by Coccinelle semantic patch.
>
> @@
> expression pdev, res, n, t, e, e1, e2;
> @@
>
> res = platform_get_resource(pdev, t, n);
> + if (!res)
> +   return -EINVAL;
> ... when != res == NULL
> e = devm_ioremap(e1, res->start, e2);
>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> [albeu@...e.fr: Fixed patch to apply on current tree]
> Signed-off-by: Alban Bedel <albeu@...e.fr>

Patch applied.

Yours,
Linus Walleij