linux-kernel - Re: [PATCH] scsi: Replace sdev_printk with printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <199ab05df000f2e8b5497a7aaecd0951321aadae.camel@wdc.com>
Date:   Tue, 27 Mar 2018 14:31:32 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>,
        "wen.yang99@....com.cn" <wen.yang99@....com.cn>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jiang.biao2@....com.cn" <jiang.biao2@....com.cn>,
        "zhong.weidong@....com.cn" <zhong.weidong@....com.cn>
Subject: Re: [PATCH] scsi: Replace sdev_printk with printk_deferred to avoid

On Thu, 2018-03-08 at 16:50 +0800, Wen Yang wrote:
> When scsi disks went wrong frequently, and with serial console 
> attached, tasks may be blocked in the following flow for more than 10s: [ ... ]

From https://bugzilla.kernel.org/show_bug.cgi?id=199003: "Hm,
printk_deferred is a bit dangerous; it moves console_unlock() to
IRQ. [ ... ] So I'd say that those two approaches

		printk_deferred + touch_nmi_watchdog

combined can do quite some harm. One thing for sure - they don't really fix
any problems."

Does that mean that this patch should be dropped?

Thanks,

Bart.