linux-kernel - Re: [PATCH 0/3] [RFC] init, tracing: Add initcall trace events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180326230212.6892a16f@vmware.local.home>
Date:   Mon, 26 Mar 2018 23:02:12 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Joel Fernandes (Google)" <joel.opensrc@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Frederic Weisbecker <fweisbec@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Abderrahmane Benbachir <abderrahmane.benbachir@...ymtl.ca>,
        AmÃ©rico Wang <xiyou.wangcong@...il.com>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 0/3] [RFC] init, tracing: Add initcall trace events

On Mon, 26 Mar 2018 18:50:32 -0700
"Joel Fernandes (Google)" <joel.opensrc@...il.com> wrote:

> > <idle>-0     [000] ...1     0.000000: initcall_level: level=console
> > <idle>-0     [000] ...1     0.000000: initcall_start: func=con_init+0x0/0x224
> > <idle>-0     [000] ...1     0.000000: initcall_finish: func=con_init+0x0/0x224 ret=0
> > <idle>-0     [000] ...1     0.000000: initcall_start: func=hvc_console_init+0x0/0x19
> > <idle>-0     [000] ...1     0.000000: initcall_finish: func=hvc_console_init+0x0/0x19 ret=0
> > <idle>-0     [000] ...1     0.000000: initcall_start: func=xen_cons_init+0x0/0x60
> > <idle>-0     [000] ...1     0.000000: initcall_finish: func=xen_cons_init+0x0/0x60 ret=0
> > <idle>-0     [000] ...1     0.000000: initcall_start: func=univ8250_console_init+0x0/0x2d
> > <idle>-0     [000] ...1     0.000000: initcall_finish: func=univ8250_console_init+0x0/0x2d ret=0  
> 
> Will this make initcall_debug not work if CONFIG_TRACEPOINTS is turned
> off? Although it builds but I think this initcall_debug feature will

Yeah probably.

> fail, maybe CONFIG_TRACEPOINTS should be selected somewhere?

Agreed. Or I can see if I can find a way to have it fall into its old
behavior when tracepoints are not configured.

-- Steve


> 
> I recently ran into some issues like this for my preemptirq
> tracepoints patch (which I will post again soon :D) where lockdep
> needed the tracepoints and I had to select it.
> 
> thanks,
> 
> - Joel