linux-kernel - RE: [PATCH -next] dm verity: make some functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <000a01d3c68b$fd4ca9d0$f7e5fd70$@foss.arm.com>
Date:   Wed, 28 Mar 2018 14:57:43 +0300
From:   <yael.chemla@...s.arm.com>
To:     "'Wei Yongjun'" <weiyongjun1@...wei.com>,
        "'Alasdair Kergon'" <agk@...hat.com>,
        "'Mike Snitzer'" <snitzer@...hat.com>
Cc:     <dm-devel@...hat.com>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH -next] dm verity: make some functions static

Hi Wei,
i'll add this fix, got this also from the kbuild test robot.
Thank you,
Yael

> -----Original Message-----
> From: Wei Yongjun <weiyongjun1@...wei.com>
> Sent: Wednesday, 28 March 2018 14:12
> To: Alasdair Kergon <agk@...hat.com>; Mike Snitzer <snitzer@...hat.com>;
> yaeceh01 <yael.chemla@...s.arm.com>
> Cc: Wei Yongjun <weiyongjun1@...wei.com>; dm-devel@...hat.com; linux-
> kernel@...r.kernel.org; kernel-janitors@...r.kernel.org
> Subject: [PATCH -next] dm verity: make some functions static
> 
> Fixes the following sparse warnings:
> 
> drivers/md/dm-verity-target.c:375:6: warning:
>  symbol 'verity_for_io_block' was not declared. Should it be static?
> drivers/md/dm-verity-target.c:403:14: warning:
>  symbol 'verity_calc_buffs_for_bv' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  drivers/md/dm-verity-target.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/md/dm-verity-target.c b/drivers/md/dm-verity-target.c
> index da35f0e..e70d4d2 100644
> --- a/drivers/md/dm-verity-target.c
> +++ b/drivers/md/dm-verity-target.c
> @@ -372,9 +372,9 @@ int verity_hash_for_block(struct dm_verity *v, struct
> dm_verity_io *io,
>  /*
>   * Calculates the digest for the given bio
>   */
> -void verity_for_io_block(struct dm_verity *v, struct dm_verity_io *io,
> -			 struct bvec_iter *iter, struct scatterlist *sg,
> -			 unsigned int *nents, unsigned int *total_len)
> +static void verity_for_io_block(struct dm_verity *v, struct dm_verity_io *io,
> +				struct bvec_iter *iter, struct scatterlist *sg,
> +				unsigned int *nents, unsigned int *total_len)
>  {
>  	unsigned int todo = 1 << v->data_dev_block_bits;
>  	struct bio *bio = dm_bio_from_per_bio_data(io, v->ti-
> >per_io_data_size); @@ -400,8 +400,9 @@ void verity_for_io_block(struct
> dm_verity *v, struct dm_verity_io *io,
>   * Calculate how many buffers are required to accommodate
>   * bio_vec starting from iter.
>   */
> -unsigned int verity_calc_buffs_for_bv(struct dm_verity *v, struct
> dm_verity_io *io,
> -				      struct bvec_iter *iter)
> +static unsigned int verity_calc_buffs_for_bv(struct dm_verity *v,
> +					     struct dm_verity_io *io,
> +					     struct bvec_iter *iter)
>  {
>  	unsigned int todo = 1 << v->data_dev_block_bits;
>  	struct bio *bio = dm_bio_from_per_bio_data(io, v->ti-
> >per_io_data_size);