linux-kernel - Re: [PATCH] clk: imx7d: Move clks_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Mar 2018 09:14:55 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Abel Vesa <abel.vesa@....com>
Cc:     Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Peter Chen <peter.chen@...escale.com>,
        Irina Tirdea <irina.tirdea@....com>,
        Anson Huang <anson.huang@....com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Ranjani Vaidyanathan <Ranjani.Vaidyanathan@....com>,
        NXP Linux Team <linux-imx@....com>,
        Dong Aisheng <b29396@...escale.com>,
        linux-clk <linux-clk@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] clk: imx7d: Move clks_init_on before any clock operations

Hi Abel,

On Tue, Mar 27, 2018 at 11:23 AM, Abel Vesa <abel.vesa@....com> wrote:
> From: Dong Aisheng <b29396@...escale.com>
>
> For init on clocks we should move it at the first place in imx7d_clocks_init()
> before any clock operations, else the clock operation may fail in case the clock
> is still not on.

The patch and the commit log does not match.

You are not moving the code block to the "first place" inside
imx7d_clocks_init(), so this is confusing.

Also, why does this need to be done only in the imx7d clock driver?