linux-kernel - Re: [PATCH 1/3] EDAC/amd64: Print ECC enabled/disabled for nodes with enabled MCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180328130028.GB20533@pd.tnic>
Date:   Wed, 28 Mar 2018 15:00:28 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Yazen Ghannam <Yazen.Ghannam@....com>
Cc:     linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] EDAC/amd64: Print ECC enabled/disabled for nodes
 with enabled MCs

On Wed, Mar 21, 2018 at 02:13:33PM -0500, Yazen Ghannam wrote:
> From: Yazen Ghannam <yazen.ghannam@....com>
> 
> It's possible that a system can be used without any DRAM populated on
> one or more physical Dies on multi-die systems. Firmware will not
> enable DRAM ECC on Dies without DRAM. Users will then see a message
> about DRAM ECC disabled on those nodes without DRAM. However, DRAM ECC
> may, in fact, be enabled on the other Dies that have DRAM.
> 
> Only print ECC enabled/disabled information for nodes that have at least
> one enabled memory channel.

So if the only reason for this is make the error messages more precise,
then let's not make it uglier than it is.

The right way to do it would be to push those checks down to
debug_display_dimm_sizes* which looks at the CS rows and the chip select
enable bits and there to differentiate between

* memory controller doesn't have DIMMs

and

* memory controller has DIMMs but ECC is disabled in the BIOS

and then print the respective informative error message. But not with a
yet another boolean which kinda takes care of F17h only and leaves the
old families as they were.

Thx.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.