linux-kernel - Re: [PATCH 2/6] drivers/irqchip: Update supports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39333f71-699c-b3b4-ec9d-eb6e83585b3d@arm.com>
Date:   Wed, 28 Mar 2018 14:47:45 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Davidlohr Bueso <dave@...olabs.net>, peterz@...radead.org,
        mingo@...nel.org, akpm@...ux-foundation.org
Cc:     linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Davidlohr Bueso <dbueso@...e.de>
Subject: Re: [PATCH 2/6] drivers/irqchip: Update supports_deactivate static
 key to modern api

On 26/03/18 22:09, Davidlohr Bueso wrote:
> No changes in semantics -- key init is true; replace
> 
> static_key_slow_dec       with   static_branch_disable
> static_key_true           with   static_branch_likely
> 
> The first is because we never actually do any couterpart incs,
> thus there is really no reference counting semantics going on.
> Use the more proper static_branch_disable() construct.
> 
> Also added a '_key' suffix to supports_deactivate, for better
> self documentation.
> 
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Jason Cooper <jason@...edaemon.net>
> Cc: Marc Zyngier <marc.zyngier@....com>
> Signed-off-by: Davidlohr Bueso <dbueso@...e.de>

Looks good to me. How do you want to get this patch merged? Either you
deal with it as part of this series, (and in which case please add my
Ack on it), or I can take it via the irqchip tree.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...