linux-kernel - Re: [PATCHv4] irqchip: arm-gic: take gic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86370ks1ve.wl-marc.zyngier@arm.com>
Date:   Wed, 28 Mar 2018 15:36:53 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Aniruddha Banerjee <aniruddha.nitd@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
        aniruddhab@...dia.com, stable@...r.kernel.org, vipink@...dia.com,
        strasi@...dia.com, swarren@...dia.com, jonathanh@...dia.com,
        talho@...dia.com, treding@...dia.com
Subject: Re: [PATCHv4] irqchip: arm-gic: take gic_lock when updating irq type

On Wed, 28 Mar 2018 14:42:00 +0100,
Aniruddha Banerjee wrote:
> 
> From: Aniruddha Banerjee <aniruddhab@...dia.com>
> 
> The kernel documentation states that the locking of the irq-chip
> registers should be handled by the irq-chip driver. In the irq-gic,
> the accesses to the irqchip are seemingly not protected and multiple
> writes to SPIs from different irq descriptors do RMW requests without
> taking the irq-chip lock. When multiple irqs call the request_irq at
> the same time, there can be a simultaneous write at the gic
> distributor, leading to a race. Acquire the gic_lock when the
> irq_type is updated.
> 
> Cc: stable@...r.kernel.org
> 
> Signed-off-by: Aniruddha Banerjee <aniruddhab@...dia.com>

I've applied this after having reworked the commit log a bit.

Thanks,

	M.

-- 
Jazz is not dead, it just smell funny.