linux-kernel - Re: [PATCH V1] mfd: da9062: use core helper regmap_reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180328152955.qrbga5fgo3ls6eje@dell>
Date:   Wed, 28 Mar 2018 16:29:55 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Steve Twiss <stwiss.opensource@...semi.com>
Cc:     LINUX-KERNEL <linux-kernel@...r.kernel.org>,
        Support Opensource <support.opensource@...semi.com>
Subject: Re: [PATCH V1] mfd: da9062: use core helper regmap_reg_range macros

On Wed, 28 Mar 2018, Steve Twiss wrote:

> From: Steve Twiss <stwiss.opensource@...semi.com>
> 
> Replace multi-line entries in the regmap_range arrays with single
> line macros: regmap_reg_range(). This will leave the static structure
> array entries for regmap_range unaltered. It will significantly reduce
> the line count in the DA9062/61 core file.
> 
> Signed-off-by: Steve Twiss <stwiss.opensource@...semi.com>
> 
> ---
> This patch applies against linux-next and v4.16-rc7
> 
> Hi,
> 
> This is a cosmetic tidy up operation. It reduces the line-count in the
> file by over 200.
> 
> It will replace regmap_range[] array entries, such as this: 
> {
>   .range_min = DA9062AA_DEVICE_ID,
>   .range_max = DA9062AA_CONFIG_ID,
> },
> 
> with a single line,
>  regmap_reg_range(DA9062AA_DEVICE_ID, DA9062AA_CONFIG_ID),
> 
> Regards,
> Steve Twiss, Dialog Semiconductor
> 
> 
>  drivers/mfd/da9062-core.c | 462 ++++++++++++----------------------------------
>  1 file changed, 114 insertions(+), 348 deletions(-)

Nice!

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog