linux-kernel - Re: [PATCH] ftrace: fix task's invalid comm of <...> when big pid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180328113522.21b4298b@gandalf.local.home>
Date:   Wed, 28 Mar 2018 11:35:22 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Wang Yu <yuwang@...ux.alibaba.com>
Cc:     Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ftrace: fix task's invalid comm of <...> when big pid

On Wed, 28 Mar 2018 20:32:27 +0800
Wang Yu <yuwang@...ux.alibaba.com> wrote:

> when pid is bigger than PID_MAX_DEFAULT, the comm of task
> is <...>, it is better use pid_max to compare
> 
> Signed-off-by: Wang Yu <yuwang@...ux.alibaba.com>
> ---
>  kernel/trace/trace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>  mode change 100644 => 100755 kernel/trace/trace.c
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> old mode 100644
> new mode 100755
> index 20a2300..0d4bc7a
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -1976,7 +1976,7 @@ static void __trace_find_cmdline(int pid, char comm[])
>  		return;
>  	}
>  
> -	if (pid > PID_MAX_DEFAULT) {
> +	if (pid > pid_max) {

Thanks! this probably should go to stable.

-- Steve

>  		strcpy(comm, "<...>");
>  		return;
>  	}