linux-kernel - Re: [PATCH] debugfs: Check return value of debugfs_real

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Mar 2018 20:05:56 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Manoj Gupta <manojgupta@...omium.org>
Cc:     Matthias Kaehlcke <mka@...omium.org>, linux-kernel@...r.kernel.org,
        Josh Poimboeuf <jpoimboe@...hat.com>
Subject: Re: [PATCH] debugfs: Check return value of debugfs_real_fops() for
 NULL

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Wed, Mar 28, 2018 at 07:47:53AM -0700, Manoj Gupta wrote:
> Please note that there is nothing wrong in the generated code, just
> that it confuses objtool.

Then fix the tool, the C code is correct :)

> Clang has simply omitted the statement where NULL is returned since
> the pointer was always dereferenced post inlining.

Then tell clang not to do that, like we tell gcc not to do that as that
is a foolish thing for a compiler to do when building the kernel.

thanks,

greg k-h